download_sysext: check for download failure #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define DownloadFailed status, and check for errors of HTTP client.
dongsupark
force-pushed
the
dongsu/status-download-failed
branch
2 times, most recently
from
dfe6c92 to
27b6fc9
Compare
wrl
requested changes
Nov 6, 2023
dongsupark
force-pushed
the
dongsu/status-download-failed
branch
from
27b6fc9 to
c3fc2b3
Compare
wrl
approved these changes
Nov 13, 2023
pothos
reviewed
Nov 13, 2023
pothos
reviewed
Nov 13, 2023
Check for HTTP status codes for immediate failures in download_and_hash, for now only 403 Forbidden and 404 Not found.
dongsupark
force-pushed
the
dongsu/status-download-failed
branch
from
c3fc2b3 to
d608308
Compare
pothos
approved these changes
Nov 14, 2023
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Nov 16, 2023
Update ue-rs to 0.1.0-r3, 2023-11-16. Pulls in flatcar/ue-rs#23 and flatcar/ue-rs#24.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define
DownloadFailedstatus, and check for errors of HTTP client.Check for HTTP status codes for immediate failures in
download_and_hash, for now only403 Forbiddenand404 Not found.Fixes #14.